[v13] Device Trust: tsh privilege elevation for TPM enrollment
#27959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-actions
bot
added
backport
size/md
tsh
github-actions
bot
requested review from
capnspacehook,
codingllama,
flyinghermit and
zmb3
codingllama
approved these changes
Jun 16, 2023
lib/devicetrust/authn/authn_test.go
Outdated
| @@ -129,7 +129,7 @@ func enrollDevice(ctx context.Context, devices devicepb.DeviceTrustServiceClient | |||
| return err | |||
| } | |||
| case devicepb.OSType_OS_TYPE_WINDOWS: | |||
| solution, err := dev.SolveTPMEnrollChallenge(resp.GetTpmChallenge()) | |||
| solution, err := dev.SolveTPMEnrollChallenge(resp.GetTpmChallenge(), false) | |||
There was a problem hiding this comment.
Missing the "/* debug */" comment?
capnspacehook
approved these changes
Jun 16, 2023
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27833 to branch/v13