Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect: Fix overlapping placeholder and keyboard shortcut in the search bar #28026

Merged
merged 2 commits into from Jun 19, 2023
Merged

Connect: Fix overlapping placeholder and keyboard shortcut in the search bar #28026

merged 2 commits into from Jun 19, 2023

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Jun 19, 2023

Before:
image

After:
image

@gzdunek gzdunek requested review from ravicious and avatus June 19, 2023 14:01
@github-actions github-actions bot requested a review from ryanclark June 19, 2023 14:02
@gzdunek gzdunek changed the title Connect: Add text-overflow: ellipsis to the search bar input Fix overlapping placeholder and keyboard shortcut in the search bar Jun 19, 2023
@gzdunek gzdunek changed the title Fix overlapping placeholder and keyboard shortcut in the search bar Connect: Fix overlapping placeholder and keyboard shortcut in the search bar Jun 19, 2023
ravicious
ravicious approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works pretty nice. 👍

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from avatus June 19, 2023 14:18
@gzdunek gzdunek enabled auto-merge June 19, 2023 14:19
@gzdunek gzdunek requested a review from avatus June 19, 2023 15:10
@gzdunek gzdunek added this pull request to the merge queue Jun 19, 2023
Merged via the queue into master with commit 453700e Jun 19, 2023
21 checks passed
@gzdunek gzdunek deleted the gzdunek/add-placeholder-ellipsis branch June 19, 2023 21:52
@public-teleport-github-review-bot
Copy link

@gzdunek See the table below for backport results.

Branch Result
branch/v13 Create PR

@gzdunek gzdunek mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravicious ravicious ravicious approved these changes

@avatus avatus avatus approved these changes

@ryanclark ryanclark ryanclark approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gzdunek @ravicious @avatus @ryanclark