Fetch CA from source of truth in case of cache miss. #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
During cache reload, CA could not be found in the local state, what creates problems for some internal processes that are not expecting that. This patch trades off performance during cache misses for more reliability by double checking with database.
klizhentas
force-pushed
the
sasha/reload-fix
branch
from
f48312c
to
99aa1e4
Compare
|
@russjones @fspmarshall this simple fix eliminates some flakiness that some customers encountered on production, so please take a look. I think I will backport this to 4.0 as well. |
russjones
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During cache reload, CA could not be found
in the local state, what creates problems for some internal processes
that are not expecting that. This patch trades off
performance during cache misses for more reliability
by double checking with database.