[v13] Respect client idle timeout setting #28202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client connections were never using the `srv.TrackingReadConn` created by the `srv.ConnectionMonitor` which caused all connections to appear idle and be disconnected whenever the client idle timeout was reached. `(srv.ConnectionMonitor) MonitorConn` now returns the provided connection which is wrapped in the tracking connection. Callers must ensure that the returned connection is used instead of the connection passed in to `MonitorConn`. Fixes #27392
github-actions
bot
added
application-access
database-access
jakule
approved these changes
Jun 26, 2023
jakule
approved these changes
Jun 26, 2023
Joerger
approved these changes
Jun 26, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27484 to branch/v13