Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit log report of kubernetes_users and kubernetes_groups #28204

Merged
merged 1 commit into from Jun 26, 2023

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Jun 23, 2023

Prior to this commit, if the user specified a filter for a user - --as - or group - --as-group -, Teleport incorrectly reported the used groups and users for the request. It reported all users and groups the user is allowed to impersonate instead of the ones actually used for the request.

This commit fixes that behavior by applying a filter based on the users and groups received from Impersonation headers.

Fixes #28166

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
@tigrato tigrato requested a review from AntonAM June 26, 2023 18:37
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from Tener June 26, 2023 21:27
@tigrato tigrato added this pull request to the merge queue Jun 26, 2023
Merged via the queue into master with commit 248c368 Jun 26, 2023
23 checks passed
@tigrato tigrato deleted the tigrato/fix-reported-kube-groups-users branch June 26, 2023 21:45
@public-teleport-github-review-bot

@tigrato See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Failed
branch/v13 Create PR

tigrato added a commit that referenced this pull request Jun 27, 2023
…28204)

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
tigrato added a commit that referenced this pull request Jun 27, 2023
…28204)

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
tigrato added a commit that referenced this pull request Jun 27, 2023
…28204)

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
github-merge-queue bot pushed a commit that referenced this pull request Jun 27, 2023
…28204) (#28338)

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
github-merge-queue bot pushed a commit that referenced this pull request Jun 27, 2023
…28204) (#28339)

Prior to this commit, if the user specified a filter for a user -
`--as` - or group - `--as-group` -, Teleport incorrectly reported the
used groups and users for the request. It reported all users and groups
the user is allowed to impersonate instead of the ones actually used for
the request.

This commit fixes that behavior by applying a filter based on the users
and groups received from Impersonation headers.

Fixes #28166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes audit log entries report multiple kubernetes_users when --as is passed
3 participants