-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF EKS example draft resources #2830
Conversation
👍 for providing an easy TF scripts for the different usage scenarios. Should we work on creating these into Terraform Modules vs just examples scripts? It would make these easier to go from POC Example -> Reusable Production Terraform. |
I like the idea of modules, yes, having configurable modules highlighting parameters would be nice, however one thing to keep in mind that lots of times folks will be copy pasting snippets as well, so they should be copy-pasteable if that's a term :) |
} | ||
|
||
provider "aws" { | ||
version = "~> 2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using 2.7.0 as this is compatible with Terraform 0.12.0. There is a fair amount of improvements in TF 0.12.0 https://www.terraform.io/upgrade-guides/0-12.html
associate_public_ip_address = true | ||
iam_instance_profile = "${aws_iam_instance_profile.demo-node.name}" | ||
image_id = "${data.aws_ami.eks-worker.id}" | ||
instance_type = "m4.large" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the smallest possible instance? Or is it possible to run on a smaller machine? Just wanted to outline expected costs for customers trying this out.
This is for #2829
Please note that we have to give folks end to end guide from scratch, you should also review and patch some missing pieces marked with `<<>>`` as variables. @webvictim can help with cleanup of terraform.
Also ping me if you have any questions.