Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light & dark themes to YAML editor #28378

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Jun 27, 2023

Closes #25413

I would like to merge it before 13.2 release.

I added data visualisation colors (Figma) and replaced the hardcoded values in the terminal theme.
Then I added a theme object for the editor. We can't use data visualisation colors directly, because for the dark theme we have to use tertiary colors, and for the light theme the primary ones.

image image

@gzdunek
Copy link
Contributor Author

gzdunek commented Jun 28, 2023

When I first implemented this, I didn't realize that TextEditor is used not only in the role editor, but also in some Discover screens. I verified how does it look like, and unfortunately it looked bad:
image

The background color we used was the same as the page background :(

I talked about this with Kenny, and he decided to use depth 3 in a standalone editor, and when displayed inline, depth 4.
image
image

I also simplified theming of the ace editor, instead of importing and overwriting ace-monokai I just provided ace-teleport theme.

@ryanclark could you take a look at it one more time? 🙏

@gzdunek gzdunek requested a review from ryanclark June 28, 2023 14:11
Copy link
Contributor

@ryanclark ryanclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…row to always render in the "expanded" state
@gzdunek gzdunek changed the title Add themes to YAML editor Add light & dark themes to YAML editor Jun 28, 2023
@gzdunek gzdunek added this pull request to the merge queue Jun 28, 2023
Merged via the queue into master with commit 95996ac Jun 28, 2023
21 checks passed
@gzdunek gzdunek deleted the gzdunek/yaml-editor-theme branch June 28, 2023 17:14
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v13 Failed

@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate CLI and YAML editor colors into light and dark themes
3 participants