-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light & dark themes to YAML editor #28378
Conversation
c00b67f
to
45c2569
Compare
When I first implemented this, I didn't realize that The background color we used was the same as the page background :( I talked about this with Kenny, and he decided to use depth 3 in a standalone editor, and when displayed inline, depth 4. I also simplified theming of the ace editor, instead of importing and overwriting @ryanclark could you take a look at it one more time? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…row to always render in the "expanded" state
Closes #25413
I would like to merge it before 13.2 release.
I added data visualisation colors (Figma) and replaced the hardcoded values in the terminal theme.
Then I added a theme object for the editor. We can't use data visualisation colors directly, because for the dark theme we have to use
tertiary
colors, and for the light theme theprimary
ones.