[v12] Add option to allow for host users not to be deleted #28433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
documentation
size/md
tctl
lxea
force-pushed
the
lxea/host-users-mode-v12
branch
from
b5a05fe
to
20fbb98
Compare
Joerger
approved these changes
Jun 28, 2023
smallinsky
approved these changes
Jun 29, 2023
This adds a new role option called create_host_users_mode which allows for it to be configured to not delete users when a session ends. The old `create_host_user` option will be deprecated with this. If the deprecated option is set, the new mode option will default to dropping users as is the current behavior. add generated protos use combined output for commands, dont set CreateHostUser fix tests ci fixes add godocs to HostUserMode constants, fix tests remain -> keep Use an enum instead of a string fix merge errors Add tests & resolve comments Resolve issues fmt
untabify resolve comments
lxea
force-pushed
the
lxea/host-users-mode-v12
branch
from
20fbb98
to
508221f
Compare
|
@lxea Is this good to merge? |
r0mant
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #26892 and #28192