Machine ID: GCP Delegated Joining support #28663
Conversation
| @@ -262,6 +263,18 @@ func (s *Server) getBotUsers(ctx context.Context) ([]types.User, error) { | |||
| return botUsers, nil | |||
| } | |||
|
|
|||
| // supportedBotJoinMethods should match SupportedJoinMethods declared in | |||
There was a problem hiding this comment.
It'd be nice to have these eventually share the same variable - but I don't want to have a dependency on lib/tbot from lib/auth at this moment - I'll have a further think about this, but this is at least better than before.
There was a problem hiding this comment.
Why not export the one in lib/auth and use it from lib/tbot?
There was a problem hiding this comment.
Yeah - I think that seems more sensible, or even possibly exporting it from api. I'd prefer to keep that out of the scope of this, as once I started pulling this thread, there's potentially some other code I'd like to move around too.
| @@ -262,6 +263,18 @@ func (s *Server) getBotUsers(ctx context.Context) ([]types.User, error) { | |||
| return botUsers, nil | |||
| } | |||
|
|
|||
| // supportedBotJoinMethods should match SupportedJoinMethods declared in | |||
There was a problem hiding this comment.
Why not export the one in lib/auth and use it from lib/tbot?
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
|
@strideynet See the table below for backport results.
|
* Add GCP joining support to tbot * Comment SPAG * Fix imports * Actually fix imports
Closes #28457
Enables GCP joining support in Machine ID using the existing support in the Teleport Auth Server - also refactors the bot joining in the Auth Server to be a bit cleaner and reduce duplication of the list of supported join methods.
Tested with a GCP VM and the following join token resource: