Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to bootstrap database service to teleport discovery boostrap #28720

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Jul 5, 2023

Implements #27737

UX:

$ teleport discovery bootstrap --attach-to-role <discovery-service-role> --database-service-role <database-service-role> 

Reading configuration at "teleport.yaml"...

Configure AWS for Discovery Service
1. Create IAM Policy "<discovery-service-policy-name>":
...

2. Create IAM Policy "<discovery-service-policy-name>Boundary":
...

3. Attach IAM policies to "<discovery-service-role>".

Configure AWS for Database Service
1. Create IAM Policy "<database-service-polcy-name>":
...

2. Create IAM Policy "<database-service-polcy-name>Boundary":
...

3. Attach IAM policies to "<database-service-role>".

Confirm? [y/N]: y
✅[AWS] Create IAM Policy "<discovery-service-policy-name>"... done.
✅[AWS] Create IAM Policy "<discovery-service-policy-name>Boundary"... done.
✅[AWS] Attach IAM policies to "<discovery-service-role>"... done.
✅[AWS] Create IAM Policy <database-service-polcy-name>"... done.
✅[AWS] Create IAM Policy "<database-service-polcy-name>Boundary"... done.
✅[AWS] Attach IAM policies to "<database-service-role>"... done.

lib/configurators/aws/aws.go Show resolved Hide resolved
tool/teleport/common/configurator.go Show resolved Hide resolved
tool/teleport/common/configurator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@GavinFrazar GavinFrazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM, even if you don't refactor to use an enum. The logic works so i'm approving

Copy link
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but somebody with more database experience (@smallinsky) should take a final pass

@greedy52 greedy52 added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit 6fed15d Jul 12, 2023
21 checks passed
@greedy52 greedy52 deleted the STeve/27737_discovery_bootstrap_db_access_role branch July 12, 2023 14:47
@public-teleport-github-review-bot

@greedy52 See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants