upgrader monitoring and alerts #28951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexfornuto,
lsgunn-teleport,
mdwn,
ptgott,
r0mant,
xinding33 and
zmb3
fspmarshall
force-pushed
the
fspmarshall/upgrader-visibility
branch
3 times, most recently
from
4e90fb5
to
0fd002b
Compare
ptgott
reviewed
Jul 11, 2023
| @@ -53,6 +53,35 @@ updates. | |||
|
|
|||
| ## Enroll instructions | |||
|
|
|||
| <Details | |||
| scope={["cloud"]} | |||
There was a problem hiding this comment.
Why is this only visible for the cloud scope?
It's also worth noting that most users tend not to use the scope switcher when they navigate between pages, so there's a good chance that users will be viewing the default (oss) scope and not see this Details box.
Finally, if this is a flow we expect most users to use, I would remove it from the Details box and make it part of the main body text.
There was a problem hiding this comment.
This feature is currently only available on cloud. This will eventually be able to be moved into the main docs, but we need to do some performance improvements first so that we can enable the feature by default. Until then, we have to scope this to cloud to avoid confusion.
We also suggest these commands in the alert so that users will be informed of this strategy even if they miss the docs.
zmb3
reviewed
Jul 11, 2023
fspmarshall
force-pushed
the
fspmarshall/upgrader-visibility
branch
from
0fd002b
to
d729f23
Compare
zmb3
approved these changes
Jul 12, 2023
fspmarshall
force-pushed
the
fspmarshall/upgrader-visibility
branch
from
d729f23
to
bcdacde
Compare
ptgott
approved these changes
Jul 14, 2023
docs/pages/management/operations/enroll-agent-into-automatic-updates.mdx
Outdated
Show resolved
Hide resolved
fspmarshall
force-pushed
the
fspmarshall/upgrader-visibility
branch
from
bcdacde
to
f8c8c44
Compare
public-teleport-github-review-bot
bot
removed request for
r0mant,
mdwn,
alexfornuto,
xinding33 and
lsgunn-teleport
fspmarshall
force-pushed
the
fspmarshall/upgrader-visibility
branch
from
f8c8c44
to
0426fa1
Compare
…pdates.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
fspmarshall
added a commit
that referenced
this pull request
Jul 17, 2023
* add rate limit stream helper * upgrader metrics & alert * add docs for discovering upgrade enroll prospects * update prehod protos * Update docs/pages/management/operations/enroll-agent-into-automatic-updates.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
* add rate limit stream helper * upgrader metrics & alert * add docs for discovering upgrade enroll prospects * update prehod protos * Update docs/pages/management/operations/enroll-agent-into-automatic-updates.mdx --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
greedy52
pushed a commit
that referenced
this pull request
Jul 19, 2023
* add rate limit stream helper * upgrader metrics & alert * add docs for discovering upgrade enroll prospects * update prehod protos * Update docs/pages/management/operations/enroll-agent-into-automatic-updates.mdx Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains a collection of minor improvements to visibility/feedback when migrating to automatic upgrades:
teleport_enrolled_in_upgrades: total number of instances enrolled in upgrades.teleport_ upgrader_counts: instances enrolled per upgrader.teleport_total_instances: total number of instances (for easy comparison).note: this PR should not be merged until after https://github.com/gravitational/cloud/pull/5219, and should not be backported to
v13until after #28847 goes live in cloud.