Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13] tctl alerts ack: Make --reason optional #28955

Merged
merged 1 commit into from Jul 12, 2023
Merged

[v13] tctl alerts ack: Make --reason optional #28955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion tool/tctl/common/alert_command.go
View file
Open in desktop
Expand Up @@ -76,9 +76,12 @@ func (c *AlertCommand) Initialize(app *kingpin.Application, config *servicecfg.C
c.alertCreate.Flag("labels", "List of labels to attach to the alert. For example: key1=value1,key2=value2.").StringVar(&c.labels)

c.alertAck = alert.Command("ack", "Acknowledge cluster alerts.")
// Be wary of making any of these flags required. Because `tctl alerts ack ls` is not an actual
// command but is handled by alertAck, any flag that is required for `tctl alerts ack` will be
// required for `tctl alerts ack ls` as well.
c.alertAck.Flag("ttl", "Time duration to acknowledge the cluster alert for.").DurationVar(&c.ttl)
c.alertAck.Flag("clear", "Clear the acknowledgment for the cluster alert.").BoolVar(&c.clear)
c.alertAck.Flag("reason", "The reason for acknowledging the cluster alert.").Required().StringVar(&c.reason)
c.alertAck.Flag("reason", "The reason for acknowledging the cluster alert.").StringVar(&c.reason)
c.alertAck.Arg("id", "The cluster alert ID.").Required().StringVar(&c.alertID)

// We add "ack ls" as a command so kingpin shows it in the help dialog - as there is a space, `tctl ack xyz` will always be
Expand Down