[v13] Add Headless Polling to Teleport Connect #28975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add WatchPendingHeadlessAuthentications rpc.
* Fix headless authentication matching logic for watcher and add test. * Move hasWatchPermissionForKind to a separate function. * Clean up hasWatchPermissionForKind. * Cleanup test code with suggestions from review.
* - Move tshd events client into the daemon service. - Replace gatway cert reissuer with a more reusable retryWithRelogin method. * Resolve comments.
* Implement headless watcher backend for Teleport Connect. * Add headless watcher to tshd daemon service. * Add SendPendingHeadlessAuthentication rpc to tshd events service. * Add UpdateHeadlessAuthenticationState rpc to the daemon service. * Address comments.
* Reduce headless watcher max backoff period to 90s; Propogate watcher error properly; Don't retry on not implemented error. * Stop watcher if it wasn't stopped already.
Joerger
force-pushed
the
joerger/v13/enable-headless-authentication-event-watching
branch
from
5cd5862
to
01764e4
Compare
Joerger
changed the title
…ake timeout less aggressive. (#29880)
|
@Joerger - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
espadolini
approved these changes
Aug 2, 2023
ravicious
approved these changes
Aug 2, 2023
|
Did you run into many conflicts when backporting this? If there were any in lib/teleterm and web/packages/teleterm, I could take a quick look to double check them. |
gzdunek
approved these changes
Aug 2, 2023
Nothing that was not easy to resolve. I reviewed the code and re-tested to make sure it still works. |
r0mant
approved these changes
Aug 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Joerger
deleted the
joerger/v13/enable-headless-authentication-event-watching
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport Headless Polling PRs to branch/v13:
WatchPendingHeadlessAuthenticationsrpc for headless polling #28234TestImportantModalSemaphore#29880