[v13] update database and kube name validation #29035
Merged
+137
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport #28841 to branch/v13
github-actions
bot
added
database-access
github-actions
bot
requested review from
greedy52,
r0mant,
smallinsky and
tigrato
smallinsky
approved these changes
Jul 13, 2023
tigrato
approved these changes
Jul 13, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28841 to branch/v13
Only difference from the original PR is I kept the name checking in
ValidateDatabaseinstead of moving it toCheckAndSetDefaults, for backwards compatibility reasons.