[v13] assist: support recording non-interactive forwarded sessions #29137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* assist: support recording non-interactive forwarded sessions * assist: add integration tests for assist command recording on agentless This also fixes a bugged openssh integration test check. * Mock OpenAI API in integration tests. Also fixes the OpenAI mock handler that was not supporting the "/v1/*" routes used in some web/ tests. * Docstrings + adressing again a feedback that got lost during a rebase * restore signer function signature * Address Jakub's feedback + diverse improvements - improve comments - simpler file creation - more efficient rsa key generation - use assert instead of require in other goroutines - only save env vars if they are Teleport-related - move more logic into newTestCredentials for readability * Update lib/srv/forward/sshserver.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Add a timeout in the ssh handler coroutine --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
jakule
approved these changes
Jul 14, 2023
zmb3
approved these changes
Jul 14, 2023
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #28677 to
branch/v13