Add api ver to path in opsgenie client #29256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Jul 18, 2023
| @@ -78,7 +78,6 @@ func (c *Config) NewBot(clusterName, webProxyAddr string) (common.MessagingBot, | |||
| } | |||
| c.ClientConfig.WebProxyURL = webProxyURL | |||
| c.ClientConfig.ClusterName = clusterName | |||
| c.ClientConfig.APIKey = c.Opsgenie.Token | |||
There was a problem hiding this comment.
This line was not meant to be committed originally.
| @@ -123,7 +123,7 @@ func (og Client) CreateAlert(ctx context.Context, reqID string, reqData RequestD | |||
| SetContext(ctx). | |||
| SetBody(body). | |||
| SetResult(&result). | |||
| Post("alerts") | |||
| Post("v2/alerts") | |||
There was a problem hiding this comment.
How come we didn't detect this issue during testing?
There was a problem hiding this comment.
Had the api kjey hardcoded locally as https://api.opsgenie.com/v2/ during testing before frontend was added. Forgot to remove it when it was, so never noticed the options were set to 'https://api.opsgenie.com' [here](value: 'https://api.opsgenie.com',).
r0mant
approved these changes
Jul 19, 2023
ryanclark
approved these changes
Jul 20, 2023
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
|
@EdwardDowling See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing api version num to api endpoint.