GenerateToken should call CreateToken not UpsertToken
#29342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
approved these changes
Jul 20, 2023
mdwn
approved these changes
Jul 20, 2023
capnspacehook
approved these changes
Jul 20, 2023
rosstimothy
reviewed
Jul 20, 2023
I can add a test, but this RPC is being removed on master in a PR I'll merge after this one - so it's only going into v13. |
|
@rosstimothy test added :) |
codingllama
approved these changes
Jul 20, 2023
public-teleport-github-review-bot
bot
removed request for
probakowski and
kimlisa
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
rosstimothy
approved these changes
Jul 20, 2023
|
@strideynet See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/gravitational/teleport-private/issues/664
Change in behaviour to ensure that GenerateToken cannot be used to modify an existing token - needs further discussion before raising this as a PR. See the above ticket for more details of the discussion.