Update Operator CRDs and add a Lint check to prevent drifts #29455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the operator's CRDs drift between the CRD and the proto stubs they are derived from. It also adds a check to prevent future drifts by forcing the manifest generation and requiring an empty diff. Fixes #29438
tigrato
requested review from
klizhentas,
russjones,
r0mant and
zmb3
as code owners
hugoShaka
approved these changes
Jul 24, 2023
r0mant
approved these changes
Jul 24, 2023
public-teleport-github-review-bot
bot
removed request for
ravicious and
marcoandredinis
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the operator's CRDs drift between the CRD and the proto stubs they are derived from.
It also adds a check to prevent future drifts by forcing the manifest generation and requiring an empty diff.
Fixes #29438
Fixes #13849