[v13] Postgres backend and Azure session storage backport #29705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Azure Blob Storage for sessions * use blob batch for part cleanup * address comments * require https/http/azblob/azblob-http scheme
* Postgres events * Update lib/events/pgevents/pgevents.go Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> * clarify setupAndMigrate * simplify AzureBeforeConnect * Add a test for pagination keys * Allow idempotent retries where appropriate * Update lib/events/pgevents/common/utils.go Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * clarify defaultRetentionPeriod * warn about expanding the searchEvents query * describe azidentity errors * move non-postgres options to the fragment * move common package to pgbk * move SetupAndMigrate to common * TestPaginationKeyRoundtrip can be t.Parallel() --------- Co-authored-by: Krzysztof Skrzętnicki <krzysztof.skrzetnicki@goteleport.com> Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
* Postgres backend * Use batch to mark read transactions as read only * Allow the backend_version creation to fail * clarify setupAndMigrate * simplify AzureBeforeConnect * Allow idempotent retries for reads * rm go.sum && go mod tidy * clarify error messages * clarify TELEPORT_PGBK_TEST_PARAMS_JSON * Describe why we always use the real clock * move SetupAndMigrate to common * update revision comment * clarify batches * actually use the context in conn.Close * give a reason why we silence logs in the change feed * order expiration deletes by expiry time * reduce defaultChangeFeedBatchSize down to 1000 we seem to be handling outrageous load fine even with 1000, and 10k (if actually hit) all but guarantees that we go over the default work_mem, forcing postgres to spill to disk; it's a tunable, anyway * parse expires as timestamptz in pollChangeFeed * implement GetName * blindly try to grant REPLICATION * default_transaction_isolation in RuntimeParams * Always use NewDefaultAzureCredential * retry unique_violation and exclusion_violation * fix pgevents.TestConfig * extract isSerializationErrorCode * polish the default_transaction_isolation check * Fix typo in Clock doc comment Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * expires is a Timestamptz --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
|
@espadolini - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
bot
added
audit-log
rosstimothy
approved these changes
Jul 27, 2023
zmb3
approved these changes
Jul 27, 2023
public-teleport-github-review-bot
bot
removed the request for review
from jakule
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #29025, #29057, #29069, #29682 to branch/v13.