propagate tctl verbose flag #29839
Merged
propagate tctl verbose flag #29839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardDowling
approved these changes
Aug 1, 2023
zmb3
approved these changes
Aug 1, 2023
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
Aug 9, 2023
Backport #29839 to branch/v12.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Backport #29839 to branch/v12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
--verboseflag intctlis used for formatting text tables.Prior behavior:
tctl get --format text --verbosedid not respect the verbose flag.I changed the interface for collections
writeTextfunc to take the verbose flag as an argument, to avoid scattering it across each collection type and ensure that all callers ofwriteTextprovide a value for text verbosity.