Refactor AWS db mocks #30086
Merged
Refactor AWS db mocks #30086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
added
refactoring
aws
greedy52
requested review from
Tener,
gabrielcorado,
GavinFrazar and
smallinsky
greedy52
commented
Aug 5, 2023
| @@ -809,6 +809,60 @@ func NewDatabasesFromRDSClusterCustomEndpoints(cluster *rds.DBCluster) (types.Da | |||
| return databases, trace.NewAggregate(errors...) | |||
| } | |||
|
|
|||
| // NewDatabasesFromRDSCluster creates all database resources from an RDS Aurora | |||
| // cluster. | |||
| func NewDatabasesFromRDSCluster(cluster *rds.DBCluster) (types.Databases, error) { | |||
There was a problem hiding this comment.
Moved logic from db fetcher to services so it's easier for another package to do the same. no change.
GavinFrazar
approved these changes
Aug 6, 2023
greedy52
force-pushed
the
STeve/p471_discovered_db_url_validation_p15
branch
from
5d84d04
to
fd1238b
Compare
smallinsky
approved these changes
Aug 7, 2023
public-teleport-github-review-bot
bot
removed request for
Tener,
gabrielcorado and
fspmarshall
Tener
approved these changes
Aug 7, 2023
greedy52
added a commit
that referenced
this pull request
Aug 14, 2023
* Refactor AWS db mocks * removew lib/services dependency * fix rds instance url, add elasticache reader endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on UT for database URL checker, I found that I need to copy a lot of mock structs from db fetchers. Decided to make a separate change just for this refactor to make review easier.
Changes:
lib/cloud/mocks/aws.goto individual files (lib/cloud/mocks/aws_xxx.go) one per AWS service typerds.DBInstance) from db fetch UTs tolib/cloud/mocks/aws_xxx.goxxx.localhostto valid AWS endpointsservices.NewXXXto one.No logic change, just moving things around.