Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] fix: Save device keys on %APPDATA%/Local instead of %APPDATA%/Roaming #30177

Merged
merged 1 commit into from Aug 8, 2023

Conversation

codingllama
Copy link
Contributor

Backport #30171 to branch/v13

Device keys are device-specific, they should not (potentially) roam to other devices.

Changelog: Save device keys on %APPDATA%/Local instead of %APPDATA%/Roaming. Windows Device Trust users should manually move the .teleport-device folder or re-enroll their device.

@zmb3
Copy link
Collaborator

zmb3 commented Aug 8, 2023

Windows Device Trust users should manually move the .teleport-device folder or re-enroll their device.

How will we make this obvious to them?

@codingllama
Copy link
Contributor Author

codingllama commented Aug 8, 2023

Windows Device Trust users should manually move the .teleport-device folder or re-enroll their device.

How will we make this obvious to them?

I'm not planning anything apart from the changelog. We are not seeing much usage, so I think this has a good chance to sneak undetected.

@codingllama codingllama added this pull request to the merge queue Aug 8, 2023
Merged via the queue into branch/v13 with commit 8781736 Aug 8, 2023
20 checks passed
@codingllama codingllama deleted the bot/backport-30171-branch/v13 branch August 8, 2023 16:44
@fheinecke fheinecke mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants