Add --current-device capabilities to tsh and tctl
#30636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @sshahcodes. |
github-actions
bot
added
size/md
tctl
codingllama
commented
Aug 17, 2023
codingllama
commented
Aug 17, 2023
zmb3
approved these changes
Aug 17, 2023
smallinsky
approved these changes
Aug 18, 2023
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
codingllama
force-pushed
the
codingllama/dt-currentdevice
branch
from
3574a6d
to
c7462d5
Compare
|
PTAL, comments addressed. |
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Aug 18, 2023
* Add the `tsh device asset-tag` hidden command * Implement registration in the fake device service * Add `--current-device` to `tsh device enroll`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Add the `tsh device asset-tag` hidden command * Implement registration in the fake device service * Add `--current-device` to `tsh device enroll`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to act on the current device more easily.
tsh device asset-tagis a debug command we planned for, but never executed. It's a simpler version oftsh device collect.tsh device enroll --current-deviceattempts to enroll the current device. It's focused on device admins, as it requires various permissions end-users typically won't have.tctlhas a--current-deviceflag added to various commands. It substitutes the need to provide--asset-tagand--os.The changes above are all focused on "day 1" experience, thus are catered to powerful Teleport users - powerful as in with various administrative permissions.