-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[buddy] Discovery service panics on GKE clusters without labels #30643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Teleport's `discovery_service` panic for a GKE cluster without labels. Co-authored-by: Tiago Silva <tfsantossilva93@gmail.com> Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
r0mant
approved these changes
Aug 17, 2023
zmb3
approved these changes
Aug 17, 2023
public-teleport-github-review-bot
bot
removed request for
bl-nero and
rosstimothy
August 17, 2023 21:14
tigrato
added a commit
that referenced
this pull request
Aug 17, 2023
Fix Teleport's `discovery_service` panic for a GKE cluster without labels. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Valeriy Khromov <valery.khromov@gmail.com>
tigrato
added a commit
that referenced
this pull request
Aug 17, 2023
Fix Teleport's `discovery_service` panic for a GKE cluster without labels. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Valeriy Khromov <valery.khromov@gmail.com>
This was referenced Aug 17, 2023
tigrato
added a commit
that referenced
this pull request
Aug 17, 2023
Fix Teleport's `discovery_service` panic for a GKE cluster without labels. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Valeriy Khromov <valery.khromov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30619.
For a GKE cluster without labels like
, Teleport with
discovery_service
enabled for GKEpanics with the following output in its log
The reason for that is because
Labels
equal tonil
for a GKE cluster without labels.Clone()
function inexp/maps
returnsnil
when anil
ispassed as an argument; see [0].
Fixed that by creating an empty labels map and then populating it using
Copy()
.Co-authored-by: @tigrato
[0] https://go-review.googlesource.com/c/exp/+/417274
buddies: #30618