Fix connection to dekstop access service when session MFA is required #30882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this we initiated connection first, then tried to issue certificate, which could require MFA check and that would lead to timeout in multiplexer, since there was no data on the connection while user was doing MFA check.
AntonAM
force-pushed
the
anton/desktop-mfa-before-connection
branch
from
f32316d
to
e8f61c6
Compare
AntonAM
added
backport/branch/v11
backport/branch/v12
backport/branch/v13
and removed
backport/branch/v11
labels
flyinghermit
approved these changes
Aug 23, 2023
public-teleport-github-review-bot
bot
removed the request for review
from lxea
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently introduced multiplexer listener for desktop access resulted in a problem with connection when session MFA was required - we initiated connection first, then tried to issue certificate, which could require MFA check and that would lead to timeout in multiplexer, since there was no data on the connection while user was doing MFA check and so multiplexer couldn't peek the data. This PR changes order of operation - now we first try to issue certificate (with MFA check if required) and only then initiate the connection.