[v13] Fix Kubernetes selected cluster #32087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kubernetes-access
size/md
tsh
mdwn
approved these changes
Sep 18, 2023
Base automatically changed from
gavinfrazar/v13-tctl-resource-selection-ux
to
gavinfrazar/v13-tsh-request-search-display-ux
September 18, 2023 23:27
GavinFrazar
force-pushed
the
gavinfrazar/v13-tsh-request-search-display-ux
branch
from
8b1bb7d
to
2749bde
Compare
Base automatically changed from
gavinfrazar/v13-tsh-request-search-display-ux
to
gavinfrazar/tsh-kube-ls-ux
September 18, 2023 23:30
backports #30167 to branch/v13. * Fix Kubernetes selected cluster Kubeconfig context name can be customized using `--set-context-name` flag. When using it, the selected Kubernetes cluster fails to correctly identify the cluster name.
GavinFrazar
force-pushed
the
gavinfrazar/v13-correct-selected-cluster
branch
from
fba0ce8
to
e1b7756
Compare
r0mant
approved these changes
Sep 19, 2023
public-teleport-github-review-bot
bot
removed request for
tigrato,
flyinghermit and
hugoShaka
backports #30252 to branch/v13. * fetch kube clusters once for login
backports #30478 to branch/v13. * select by labels, query predicate, name, and/or prefix of name. * fix --cluster flag not being propagated
backports #30531 to branch/v13.
backports #31744 to branch/v13.
backports #31689 to branch/v13. * disallow prefix matching * select by exact name match first, * otherwise look for unambiguous discovered name label match. * look for an active db to resolve discovered name match ambiguity. * add more predicate builder helpers * check for db name in not found error for stale cert hint * no error status on tsh db logout with no logged in dbs * remove dead code * refactor helper funcs to simplify code and make it easier to test * test complex database selection * test findActiveDatabase * test choosing one db by discovered name * add more resource selectors tests * test formatDatabaseLoginCommand * add debug logging for db selection
* fix retry with relogin for ambiguous clusters * consolidate test setup for login/proxy kube selection tests * add more test cases for kube selection * remove prefix testing * add origin cloud label in tests * refactor the check for multiple cluster login into a func
Backports #31916 to branch/v13. * remove prefix matching in tctl * replace prefix matching with exact discovered name match as a fallback when no resource full name matches the name given by a user * refactor test helpers * avoid decoding yaml/json into already initialized var
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #30167 to branch/v13.
stacked on #32086
(Multiple PRs stacked on this one were merged into this PR before merging it into branch/v13. Here are the change logs):
changelog:
tsh [proxy | db | kube]subcommands now support--queryand--labelsoptional arguments.changelog:
tshandtctlcan select an auto-discovered database or Kubernetes cluster by its original name instead of the more detailed name generated by the v14+ Teleport Discovery service.