Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for access request resource to cache #3223

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

fspmarshall
Copy link
Contributor

Cache was missing support for access requests, causing watchers to hang indefinitely without receiving events when cache was in use.

Fixes #3213

Copy link
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me as long as all the tests pass and functionality is good etc.

lib/cache/cache_test.go Outdated Show resolved Hide resolved
lib/cache/cache_test.go Outdated Show resolved Hide resolved
lib/cache/cache_test.go Outdated Show resolved Hide resolved
lib/cache/cache_test.go Outdated Show resolved Hide resolved
lib/cache/cache_test.go Outdated Show resolved Hide resolved
@fspmarshall fspmarshall force-pushed the fspmarshall/fix-access-request-cache branch from ab425c1 to 8e08c30 Compare December 19, 2019 20:09
lib/cache/collections.go Outdated Show resolved Hide resolved
tool/tsh/tsh.go Outdated Show resolved Hide resolved
Cache was missing support for access requests, causing
watchers to hang indefinitely without receiving events
when cache was in use.
@fspmarshall fspmarshall force-pushed the fspmarshall/fix-access-request-cache branch from 8e08c30 to ccb6e36 Compare December 19, 2019 21:46
@klizhentas klizhentas merged commit 568e185 into master Dec 19, 2019
@fspmarshall fspmarshall deleted the fspmarshall/fix-access-request-cache branch December 19, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

teleport cache & tctl requests approve issue
3 participants