[v14] Use cluster name from ServerIdentity for Auth multiplexer #32352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAM
force-pushed
the
anton/fix-auth-multiplexer-cluster-name
branch
from
0250469
to
377d750
Compare
Proxy sends signed PROXY headers using cluster name from ServerIdentity. If cluster name in file config was changed it didn't match with original cluster name and auth service couldn't verify Proxy's signed headers.
AntonAM
force-pushed
the
anton/fix-auth-multiplexer-cluster-name
branch
from
377d750
to
47752b2
Compare
jentfoo
approved these changes
Sep 22, 2023
tigrato
approved these changes
Sep 22, 2023
capnspacehook
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure cluster name on Auth listener is always correct from signed PROXY headers point of view (all other multiplexer listeners already use cluster name from ServerIdentity) and removes skipping ErrNonLocalCluster error in multiplexer. Proxy sends signed PROXY headers using cluster name from ServerIdentity. If cluster name in file config was changed it didn't match with original cluster name and auth service couldn't verify Proxy's signed headers.
This is follow up for #32068
Fixes #32066