Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscoveryConfig: WebAPI CRUD #32591

Merged
merged 2 commits into from Oct 12, 2023
Merged

Conversation

marcoandredinis
Copy link
Contributor

@marcoandredinis marcoandredinis commented Sep 26, 2023

Context: #25494

This PR adds the CRUD operations to the WebAPI.

@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover backport/branch/v14 labels Sep 26, 2023
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch 2 times, most recently from 017e419 to 9937d8e Compare September 28, 2023 10:14
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch from 9937d8e to 6dfa8be Compare September 28, 2023 10:23
@marcoandredinis marcoandredinis changed the base branch from marco/discovery_config_init_resource_tctl to master September 28, 2023 10:25
@marcoandredinis marcoandredinis changed the base branch from master to marco/discovery_config_init_resource_tctl September 28, 2023 10:25
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch from 6dfa8be to 497c64f Compare September 28, 2023 10:43
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch 2 times, most recently from 7fad84d to b809d6d Compare October 2, 2023 17:52
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_webapi branch 2 times, most recently from 287e459 to e30b16c Compare October 2, 2023 17:59
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch from a65d02f to 24dde14 Compare October 3, 2023 13:52
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch 2 times, most recently from 97678c9 to 2a3c17c Compare October 4, 2023 17:42
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch from 2a3c17c to 5af94ee Compare October 10, 2023 09:11
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_init_resource_tctl branch from 5af94ee to 972995d Compare October 11, 2023 10:06
Base automatically changed from marco/discovery_config_init_resource_tctl to master October 11, 2023 10:42
@marcoandredinis marcoandredinis force-pushed the marco/discovery_config_webapi branch 4 times, most recently from 062f7cc to 05f5bb5 Compare October 11, 2023 11:29
@marcoandredinis marcoandredinis marked this pull request as ready for review October 11, 2023 14:05
lib/web/discoveryconfig.go Show resolved Hide resolved
lib/web/discoveryconfig_test.go Show resolved Hide resolved
Copy link
Contributor

@mdwn mdwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 12, 2023
Merged via the queue into master with commit 44ca346 Oct 12, 2023
28 checks passed
@marcoandredinis marcoandredinis deleted the marco/discovery_config_webapi branch October 12, 2023 17:55
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v14 discover Issues related to Teleport Discover size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants