Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote pool of signed certs when exec into leaf clusters #32644

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix remote pool of signed certs when exec into leaf clusters #32644

merged 2 commits into from
Sep 28, 2023

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Sep 27, 2023

This PR fixes the list of acceptable CAs from the leaf cluster when exec into a leaf cluster pod.

Fixes #32380

@tigrato
Fix remote pool of signed certs when exec into leaf clusters
f40c19b 
This PR fixes the list of acceptable CAs from the leaf cluster when
exec into a leaf cluster pod.

Fixes #32380

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato mentioned this pull request Sep 27, 2023
Closed
jakule
jakule reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to add a test that covers this scenario?

@tigrato
Copy link
Contributor Author

tigrato commented Sep 28, 2023

How hard would it be to add a test that covers this scenario?

Added in b17e09c including checks for clone

@tigrato tigrato added this pull request to the merge queue Sep 28, 2023
Merged via the queue into master with commit 61e04e0 Sep 28, 2023
26 checks passed
@tigrato tigrato deleted the tigrato/fix-tls-conf-kube branch September 28, 2023 18:12
@public-teleport-github-review-bot
Copy link

@tigrato See the table below for backport results.

Branch Result
branch/v14 Create PR

@tigrato tigrato mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakule jakule jakule approved these changes

@gzdunek gzdunek gzdunek approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 kubernetes-access size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to verify certificate while issue kubectl exec
3 participants
@tigrato @jakule @gzdunek