Add initial command to session trackers #32947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kubernetes-access
size/sm
tsh
ibeckermayer
approved these changes
Oct 4, 2023
|
Is there some mechanism by which we prevent the user from "spoofing" which command they used? |
ravicious
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
The UI looks good even with longer commands like top -o command -o cpu -o boosts -o cycles -o cow -o user -o vsize -o csw -o threads -o ports -o ppid (an arbitrary one just to pad the length of the command).
The type check is failing because session fixtures are missing. I recommend executing yarn type-check -w so that you get instant feedback in watch mode.
It'd be good to add some normal and long commands to some of the sessions in fixtures so that the stories for them give a preview of this feature (yarn storybook followed by opening http://localhost:9002/?path=/story/teleport-activesessions--loaded).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
When user starts a session, we do not report the initial command used which causes visibility problems to moderators when they need to figure out if they join or not the session. This PR exposes the intial command for SSH and Kubernetes so moderators can decide if they want to join the session or not based on the initial command. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/add-intial-command-active-sessions
branch
from
beb2a4f
to
7cfcf46
Compare
tigrato
added a commit
that referenced
this pull request
Oct 7, 2023
When user starts a session, we do not report the initial command used which causes visibility problems to moderators when they need to figure out if they join or not the session. This PR exposes the intial command for SSH and Kubernetes so moderators can decide if they want to join the session or not based on the initial command. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
When user starts a session, we do not report the initial command used which causes visibility problems to moderators when they need to figure out if they join or not the session. This PR exposes the intial command for SSH and Kubernetes so moderators can decide if they want to join the session or not based on the initial command. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user starts a session, we do not report the initial command used which causes visibility problems to moderators when they need to figure out if they join or not the session.
This PR exposes the initial command for SSH and Kubernetes so moderators can decide if they want to join the session or not based on the initial command.