OneOff Script: use ent build if cluster is Enterprise #33061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
discover
marcoandredinis
force-pushed
the
marco/oneoff_use_ent_bin
branch
from
d5a331c
to
f40e492
Compare
greedy52
approved these changes
Oct 6, 2023
|
The flaky tester is failing because the test times out. Can I please get a waiver on this flaky test? (admins only? cc @r0mant ) I can change the compression level to BestSpeed for this test if that's preferable |
@marcoandredinis Would this speed up the test? If so, that would be better, yes. |
marcoandredinis
force-pushed
the
marco/oneoff_use_ent_bin
branch
from
f40e492
to
8a48969
Compare
|
It goes from 4s to less than a second (locally at least) |
avatus
approved these changes
Oct 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
We were always using the OSS version of teleport in the one-off scripts. This PR changes that to pick the correct version depending on the running version in the Proxy.
marcoandredinis
force-pushed
the
marco/oneoff_use_ent_bin
branch
from
8a48969
to
aa4d6a4
Compare
|
@marcoandredinis See the table below for backport results.
|
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always using the OSS version of teleport in the one-off scripts.
This PR changes that to pick the correct version depending on the running version in the Proxy.