[v14] Header Connection: close causes kubectl to fail exec
#33172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header `Connection: close` causes failure in kubetl when it upgrades the connection to SPDY. The `ReadTimeout` and `WriteTimeout` are known to cause problems to Kubernetes watch streams. Fixes #33020 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
added
the
tsh
github-actions
bot
requested review from
greedy52,
jakule,
marcoandredinis and
ravicious
GavinFrazar
approved these changes
Oct 9, 2023
marcoandredinis
approved these changes
Oct 9, 2023
ravicious
approved these changes
Oct 10, 2023
public-teleport-github-review-bot
bot
removed request for
greedy52 and
jakule
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #33050 to branch/v14