[v14] utils.RecursiveChown: Fix for Privilege Escalation due to following symlinks #33248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change a user could exploit Teleports privileged access to `chown` arbitrary files on the system. This is due to the directory being changed first, allowing a small time window where a user can remove or rename the still `root` owned files with a symlink. The added tests help show this issue in a more controlled way. A switch to `os.Lchown` avoids the risk in following symlinks to files. In addition, in order to remove the risk for hardlinks (notably on OSX with reduced hardlink protections), as well as risks with directory symlinks, the folder structure is inspected before any `chown` operation. And then the files are updated before their parent directories.
None of these cases should expect a symlink that would need to be followed.
github-actions
bot
added
audit-log
r0mant
approved these changes
Oct 10, 2023
russjones
approved these changes
Oct 10, 2023
zmb3
approved these changes
Oct 10, 2023
public-teleport-github-review-bot
bot
removed request for
Tener,
wadells,
jimbishopp and
nklaassen
lsgunn-teleport
pushed a commit
that referenced
this pull request
Oct 11, 2023
…wing symlinks (#33248) * utils.RecursiveChown: Harden against user access race conditions Prior to this change a user could exploit Teleports privileged access to `chown` arbitrary files on the system. This is due to the directory being changed first, allowing a small time window where a user can remove or rename the still `root` owned files with a symlink. The added tests help show this issue in a more controlled way. A switch to `os.Lchown` avoids the risk in following symlinks to files. In addition, in order to remove the risk for hardlinks (notably on OSX with reduced hardlink protections), as well as risks with directory symlinks, the folder structure is inspected before any `chown` operation. And then the files are updated before their parent directories. * Update other instances of `os.Chown` to `os.Lchown` None of these cases should expect a symlink that would need to be followed.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v14 OSS port for private security fix: https://github.com/gravitational/teleport-private/pull/1077
Backport for OSS master PR: #33244