Update @babel/core to 7.23.2 and dedupe babel deps #33355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npx yarn-deduplicate yarn.lock --scopes @babel
gzdunek
approved these changes
Oct 12, 2023
jentfoo
approved these changes
Oct 12, 2023
ryanclark
approved these changes
Oct 13, 2023
|
@ravicious See the table below for backport results.
|
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes arbitrary code execution in Babel (GHSA-67hx-6x53-jw92). Arguably, we don't seem to be vulnerable as we don't use neither @babel/plugin-transform-runtime nor
useBuiltInsand we don't use Babel polyfills.Unfortunately, Yarn v1 doesn't hoist deps correctly, so just changing the version range in
web/packages/build/package.jsonwasn't enough. I noticed that there's a lot of overlapping ranges between our Babel deps and Babel deps used by Storybook.npx yarn-deduplicate yarn.lock --scopes @babeldeduplicated them nicely. I also took the time to deduplicate browserslist and caniuse-lite since updates of those packages are fairly straightforward to check.I verified that things are still compiling correctly by running
yarn storybook,yarn start-termandmake build/teleport.