Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Web: Add notification store #33381

Merged
merged 9 commits into from Oct 13, 2023
Merged

[v14] Web: Add notification store #33381

merged 9 commits into from Oct 13, 2023

Commits on Oct 12, 2023

  1. Add notification bell to top bar 

    Also fixes topbar.test act warnings (even though tests passed)
    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    440523c View commit details
    Browse the repository at this point in the history

  2. Add attention dot to navigation switcher

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    74dbf8d View commit details
    Browse the repository at this point in the history

  3. Add attention dot to navigation item

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4cf4fd4 View commit details
    Browse the repository at this point in the history

  4. Create store notification and enable it

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    70a2afe View commit details
    Browse the repository at this point in the history

  5. Address review 

    - Made store notification type more generic
- Drop opactiy styling for top bar drop downs
- Use assertUnreachable in switch cases
    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7b9e19a View commit details
    Browse the repository at this point in the history

  6. Address CR

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a7b9788 View commit details
    Browse the repository at this point in the history

  7. Fix import path and rename file

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8d1d97c View commit details
    Browse the repository at this point in the history

  8. Leave a TODO comment

    @kimlisa
    kimlisa authored and github-actions committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dd69827 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge branch 'branch/v14' into bot/backport-32970-branch/v14

    @kimlisa
    kimlisa committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    01b9de6 View commit details
    Browse the repository at this point in the history