[v14] Fix Assume Roles switch back, don't delete role if access list is using it. #33834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng it. When switching back to the regular user permissions after assuming roles via an access request, Teleport will now use the user login state to ensure that access list permissions are taken into account. Additionally, users will not be able to delete roles if they are in use by an access list. Finally, when refreshing the user while extending a web session, the user login state will be regenerated and used for permissions.
r0mant
reviewed
Oct 23, 2023
| } | ||
|
|
||
| var nextToken string | ||
| for { |
There was a problem hiding this comment.
Is there no "forEach" kind of helper method for access lists already somewhere?
There was a problem hiding this comment.
No, unfortunately. :-(
lib/auth/access.go
Outdated
| } | ||
|
|
||
| for _, accessList := range accessLists { | ||
| for _, r := range accessList.Spec.Grants.Roles { |
There was a problem hiding this comment.
Nit: I think we have a "contains" method for string slices somewhere in utils which will make this code a bit cleaner and avoid 3rd nested for loop.
There was a problem hiding this comment.
I've elected to use slices instead here, let me know what you think.
There was a problem hiding this comment.
Just dropping this here: #33851 - this is the equivalent slices change on master that keeps master and branch/v14 in sync.
r0mant
approved these changes
Oct 23, 2023
camscale
approved these changes
Oct 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #33746 to branch/v14.