New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue auto-provisioned PostgreSQL user may keep old roles indefinitely #33969
Merged
greedy52
merged 2 commits into
master
from
STeve/p998_user_active_connection_role_changed
Nov 1, 2023
Merged
Fix an issue auto-provisioned PostgreSQL user may keep old roles indefinitely #33969
greedy52
merged 2 commits into
master
from
STeve/p998_user_active_connection_role_changed
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
added
security
Security Issues
backport/branch/v13
changelog
backport/branch/v14
labels
Oct 27, 2023
greedy52
force-pushed
the
STeve/p998_user_active_connection_role_changed
branch
from
October 27, 2023 15:35
f594013
to
dd8173a
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
github-actions
bot
added
database-access
Database access related issues and PRs
size/sm
labels
Oct 27, 2023
gabrielcorado
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tener
approved these changes
Oct 30, 2023
smallinsky
approved these changes
Nov 1, 2023
greedy52
added a commit
that referenced
this pull request
Nov 1, 2023
…finitely (#33969) * Fix an issue auto-provisioned PostgreSQL user may keep old roles indefinitely * upper case the sql scripts
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v13
backport/branch/v14
database-access
Database access related issues and PRs
security
Security Issues
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix an issue auto-provisioned PostgreSQL user may keep old roles indefinitely
Fixes https://github.com/gravitational/teleport-private/issues/998
change:
This PR also UPPERCASE the existing SQL scripts to be consistent, see discussion #33307 (comment)
Note that all new implementations of auto-user provisioning (MySQL/MariaDB/Redshift) already include similar fixes for this issue in their initial implementation.