Support Redshift auto provisioned user deletion #34006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
database-access
greedy52
approved these changes
Oct 30, 2023
smallinsky
approved these changes
Nov 1, 2023
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
gabrielcorado
deleted the
gabrielcorado/redshift-delete-provisioned-user
branch
greedy52
pushed a commit
that referenced
this pull request
Nov 1, 2023
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Database Automatic User Provisioning support for Redshift (#33307) * Database Automatic User Provisioning support for Redshift * capitalize sql script * DeleteUser to fallback to deactivate. * add TPxxx code to RAISE messages * fix missing space in scripts * feat(postgres): support auto-provisioned user deletion Redshift (#34006) --------- Co-authored-by: Gabriel Corado <gabriel.oliveira@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few differences from the regular PostgreSQL deletion procedure:
Given these differences, the Redshift procedure is slightly simple as it doesn't need to return any state (as it won't be accessible in case of exception). Also, on the application side, we handle the
DROP USERas an OK error to happen.Alternatively, to match assert the procedure error, we could turn the procedure into a
NOATOMICprocedure, which does not throw the exception if it is handled. However, that would make theteleport_deactivate_userprocedure non-atomic (which might not be desired), called from the delete one.changelog: Support Redshift auto-provisioned users deletion.