Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer Scripts: use bash instead of sh #34039

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Installer Scripts: use bash instead of sh #34039

merged 2 commits into from
Nov 2, 2023

Commits on Oct 30, 2023

  1. Installer Scripts: use bash instead of sh 

    The agentless version of this script uses `bash`.
Using `bash` over `sh` should help the maitenance of the script.
It's being used for the agentless version and the node join script
`sh` is sometimes an alias to `bash`, and testing this script in those
systems might lead to assume that the script is working fine, even tho
when running in a real `sh` it will fail.
    @marcoandredinis
    marcoandredinis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6555e41 View commit details
    Browse the repository at this point in the history

  2. use the same expression that is being used in agentless

    @marcoandredinis
    marcoandredinis committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e05b5c9 View commit details
    Browse the repository at this point in the history