New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo for Windows artifact build pipeline GHA migration #34273
Conversation
98ac3f6
to
a02b98e
Compare
Added do-not-merge label until the pending teleport.e PR is merged, and the e ref is updated in this PR |
I don't know enough about our build pipelines to provide a meaningful review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Pretty standard stuff in my experience changing the pipelines over to GHA.
The powershell also seems fine, but I have little experience to know if there might be better ways to be doing things or if there are subtle bugs. But it is quite readable and looks straightforward enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love those red diffs!
@fheinecke See the table below for backport results.
|
* Update repo for Windows artifact build pipeline GHA migration * Remove base64 encoding of release server private key * Compress-archive path fix * Updated e ref and resigned dronegen
This PR includes several changes, all required for moving the Windows build pipeline to GHA:
e
ref [PENDINGteleport.e
PR]The actual Windows build workflows in theThis is now available here.teleport.e
repo are not quite ready for review, however they are very close and these changes are stable enough that I'd like to open this up for review.Reviewers, we (Gravitational) have a week (total) to merge and backport this and at least two other PRs, test them all together, and cut at least one new full release. If all this is not completed by then, then we lose the ability to cut new releases. Please review this as soon as possible so that I can get fixes in quickly.
Changelog: Updated the code signing certificate for Windows artifacts