Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Disable AWS IMDSv1 fallback and enforce use of FIPS endpoints #34433

Merged
merged 1 commit into from Nov 16, 2023

Conversation

reedloden
Copy link
Contributor

Backport #34170 to branch/v14

Two changes to AWS SDK usage:

Teleport should never use AWS IMDSv1 for requests, so disable the
ability to fallback to it, as it could be a malicious attempt to
downgrade security.

Teleport generally prefers FIPS endpoints when in FIPS mode, but
there were a few places that were not selecting the FIPS endpoints.
Ensure that the FIPS endpoints if BoringCrypto is being used.
@reedloden reedloden self-assigned this Nov 9, 2023
@github-actions github-actions bot added application-access audit-log Issues related to Teleports Audit Log backport size/sm labels Nov 9, 2023
@reedloden reedloden added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@reedloden reedloden added this pull request to the merge queue Nov 16, 2023
Merged via the queue into branch/v14 with commit d135b59 Nov 16, 2023
32 checks passed
@reedloden reedloden deleted the bot/backport-34170-branch/v14 branch November 16, 2023 20:33
@camscale camscale mentioned this pull request Nov 16, 2023
reedloden added a commit that referenced this pull request Nov 29, 2023
…points"

This reverts commit fb4e20a (#34433).

After discussion, keeping this change on `master` only, as it has
already caused one customer regression (#34804).
reedloden added a commit that referenced this pull request Nov 29, 2023
…points"

This reverts commit fb4e20a (#34433).

After discussion, keeping this change on `master` only, as it has
already caused one customer regression (#34804).
reedloden added a commit that referenced this pull request Nov 29, 2023
…points"

This reverts commit fb4e20a (#34433).

After discussion, keeping this change on `master` only, as it has
already caused one customer regression (#34804).
reedloden added a commit that referenced this pull request Nov 29, 2023
…points"

This reverts commit fb4e20a (#34433).

After discussion, keeping this change on `master` only, as it has
already caused one customer regression (#34804).
github-merge-queue bot pushed a commit that referenced this pull request Nov 30, 2023
…points" (#35169)

This reverts commit fb4e20a (#34433).

After discussion, keeping this change on `master` only, as it has
already caused one customer regression (#34804).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-access audit-log Issues related to Teleports Audit Log backport size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants