Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Update distroless images to use Debian 12 #34878

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

reedloden
Copy link
Contributor

@reedloden reedloden commented Nov 22, 2023

Backport of #31620.

e companion -- https://github.com/gravitational/teleport.e/pull/2718

https://github.com/GoogleContainerTools/distroless#debian-12

Note that the debian12 images no longer include OpenSSL, which we don't need anyway, as we statically link our own copy for tsh and other purposes.

Also, add Debian 12 to various places, as a supported OS.

Other included changes:

  • Standardize how we select which distroless release to use.
  • Ensure a specific distroless version is used instead of latest.
  • Add new Amazon Linux and Oracle Linux releases to compatibility testing.
  • Correct s/MacOS/macOS/ in install script.

changelog: Update distroless images to use Debian 12

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@reedloden reedloden requested review from jakule, zmb3 and ptgott and removed request for klizhentas, r0mant, zmb3, xinding33 and ptgott November 22, 2023 09:45
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@hugoShaka
Copy link
Contributor

I'm a bit concerned about backporting the part, even if it's only in the test matrix

Remove Debian 8 and 9, as they aren't receiving any security updates.

In theory. users are not using those anymore. In practice, we keep fixing bugs happening on ubuntu 14.04

@reedloden
Copy link
Contributor Author

I'm a bit concerned about backporting the part, even if it's only in the test matrix

Remove Debian 8 and 9, as they aren't receiving any security updates.

In theory. users are not using those anymore. In practice, we keep fixing bugs happening on ubuntu 14.04

Sure, happy to keep that removal to master only. Will re-add it to the backports.

Copy link
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedloden I'm not sure if this is related, but some tests are failing on this PR.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from zmb3 November 27, 2023 19:27
@reedloden reedloden added this pull request to the merge queue Nov 27, 2023
@reedloden reedloden removed this pull request from the merge queue due to a manual request Nov 27, 2023
https://github.com/GoogleContainerTools/distroless#debian-12

Note that the debian12 images no longer include OpenSSL, which we
don't need anyway, as we statically link our own copy for tsh and
other purposes.

Also, add Debian 12 to various places, as a supported OS.

Other included changes:
* Standardize how we select which distroless release to use.
* Ensure a specific distroless version is used instead of latest.
* Add new Amazon Linux and Oracle Linux releases to compatibility testing.
* Correct s/MacOS/macOS/ in install script.
@reedloden reedloden added this pull request to the merge queue Nov 27, 2023
Merged via the queue into branch/v14 with commit 2507c4d Nov 27, 2023
36 checks passed
@reedloden reedloden deleted the reed/backport-31620/v14 branch November 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants