[v14] auth: fix panic with v14 clients and sync recording modes #35183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #34793 we added a fix for missing audit events when v13 agents use sync recording modes against a v14 cluster. This fix missed a few events that used to be filtered out by TeeStreamer, and as a result we ended up writing session recording data for desktop and app sesions to the audit log. This data eventually caused a panic, likely due to an integer overflow.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
changed the title
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
r0mant
approved these changes
Nov 30, 2023
tigrato
approved these changes
Nov 30, 2023
public-teleport-github-review-bot
bot
removed request for
capnspacehook,
atburke and
rosstimothy
rosstimothy
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34793 we added a fix for missing audit events when v13 agents use sync recording modes against a v14 cluster. This fix missed a few events that used to be filtered out by TeeStreamer, and as a result we ended up writing session recording data for desktop and app sessions to the audit log. This data eventually caused a panic, likely due to an integer overflow.
Changelog: fix bug that could cause app and desktop session recording events to be written to the audit log