Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User login state generator copies user labels. #35487

Merged
merged 2 commits into from Dec 7, 2023

Conversation

mdwn
Copy link
Contributor

@mdwn mdwn commented Dec 7, 2023

The user login state generator will now copy the user labels to the user login state. This simplifies a few things in our bot functionality, so unneeded bits have been removed as a result.

Closes #35443

changelog: Fix bot's unable to view or approve access requests due to ULS overwriting.

Note: This should be verified by @strideynet before being committed.

The user login state generator will now copy the user labels to the user
login state. This simplifies a few things in our bot functionality, so
unneeded bits have been removed as a result.
Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and fixes the issue 👍

@strideynet
Copy link
Contributor

Closes #35443

@strideynet strideynet added this pull request to the merge queue Dec 7, 2023
Merged via the queue into master with commit 8c32549 Dec 7, 2023
34 checks passed
@strideynet strideynet deleted the mike.wilson/uls-generator-copies-labels branch December 7, 2023 19:19
@public-teleport-github-review-bot

@mdwn See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tbot attempt to approve access request is denied
3 participants