Prevent panic in web app transport #35501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case where no app servers were available was not handled and resulted in exceeding the bounds of the app servers slice. When no servers are available now the slice is set to nil instead of trying to shift it beyond the bounds. A test was added to validate that the panic is not possible any more. Fixes #35460
rosstimothy
force-pushed
the
tross/fix_app_transport_panic
branch
from
36ce870
to
36879f9
Compare
tigrato
approved these changes
Dec 7, 2023
zmb3
approved these changes
Dec 7, 2023
public-teleport-github-review-bot
bot
removed the request for review
from tcsc
|
@rosstimothy See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where no app servers were available was not handled and resulted in exceeding the bounds of the app servers slice. When no servers are available now the slice is set to nil instead of trying to shift it beyond the bounds. A test was added to validate that the panic is not possible any more.
Fixes #35460
Changelog: Prevent panic when dialing a deleted Application Server