Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Add "Show All Labels/Collapse All Labels" button to Unified List View #35526

Merged
merged 1 commit into from Dec 11, 2023

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Dec 7, 2023

Purpose

Adds a button to expand or collapse all labels from all rows in a single click. This is for users who want to see all labels for all rows but don't want to have to go through each row and manually expand them.

This preference is stored in the user's user preferences and will persist between sessions.

Figma design

Demo

expandalllabels.mov

Copy link

github-actions bot commented Dec 7, 2023

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@rudream rudream requested a review from avatus December 7, 2023 21:46
@zmb3
Copy link
Collaborator

zmb3 commented Dec 8, 2023

cc @gzdunek in case this impacts Teleport Connect

@gzdunek
Copy link
Contributor

gzdunek commented Dec 8, 2023

Yes, I will have to add support for this preference property.

Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this works great! Tried to break it locally and I couldn't. Also, it makes me realize how messy it looks with all the labels shown so maybe hiding them was a good idea in the first place 🤔

@rudream rudream added this pull request to the merge queue Dec 11, 2023
Merged via the queue into master with commit ffb3e18 Dec 11, 2023
39 checks passed
@rudream rudream deleted the yassine/show-all-labels branch December 11, 2023 21:11
@public-teleport-github-review-bot

@rudream See the table below for backport results.

Branch Result
branch/v14 Failed

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@rudream rudream added the no-changelog Indicates that a PR does not require a changelog entry label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants