New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAML IdP attribute mapping types and config handler #35584
Conversation
…/attribute-mapping-types
- Check for duplciate attribute names
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few stylistic nitpicks.
- use map instead of slice for finding duplicate names
Friendly ping @xacrimon @fspmarshall @mdwn |
…/attribute-mapping-types
@flyinghermit See the table below for backport results.
|
Supports attribute mapping configuration in
saml_idp_service_provider
spec.value of
name_format
can be one of the following:urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified
. Used as a default value.urn:oasis:names:tc:SAML:2.0:attrname-format:uri
.urn:oasis:names:tc:SAML:2.0:attrname-format:basic
.Reference spec file:
RFD: https://github.com/gravitational/teleport.e/pull/2801
see #34725, https://github.com/gravitational/teleport.e/issues/2692
changelog: attribute mapping in
saml_idp_service_provider
spec.