[v14] Add vpc-id label to RDS Auto-Discover converter
#35890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
database-access
r0mant
approved these changes
Dec 19, 2023
marcoandredinis
force-pushed
the
bot/backport-35775-branch/v14
branch
from
970df8a
to
cb7a6f4
Compare
kimlisa
approved these changes
Dec 20, 2023
public-teleport-github-review-bot
bot
removed the request for review
from ibeckermayer
This PR adds a new label to RDS Instances and RDS Clusters to identify its VPC ID. For Clusters, an additional fetch was necessary because RDS DescribeDBCluster does not return its VPC. So, a DescribeDBInstance must be performed to obtain that information from one of its members. This will allow us to deploy a DatabaseService in a specific VPC and only proxy the Databases that also belong to that VPC.
marcoandredinis
force-pushed
the
bot/backport-35775-branch/v14
branch
from
cb7a6f4
to
c82c59d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #35775 to branch/v14
changelog: add vpc-id as a label to auto-discovered RDS databases