Fix agent forwarding for multi-session connections #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
force-pushed
the
fspmarshall/fix-agent-forwarding
branch
from
d74855a
to
655b7c0
Compare
fspmarshall
requested review from
awly,
klizhentas,
russjones and
webvictim
as code owners
webvictim
reviewed
Apr 22, 2020
|
retest this please |
fspmarshall
force-pushed
the
fspmarshall/fix-agent-forwarding
branch
3 times, most recently
from
f928384
to
7b1dcb3
Compare
|
retest this please |
fspmarshall
force-pushed
the
fspmarshall/fix-agent-forwarding
branch
from
7b1dcb3
to
d24e2ab
Compare
russjones
reviewed
Apr 24, 2020
fspmarshall
force-pushed
the
fspmarshall/fix-agent-forwarding
branch
from
d24e2ab
to
b4bf099
Compare
fspmarshall
commented
Apr 27, 2020
russjones
approved these changes
Apr 27, 2020
| c.RLock() | ||
| defer c.RUnlock() | ||
| return c.agent | ||
| if c.Parent == nil { |
There was a problem hiding this comment.
Should GetAgent and GetAgentChannel return an error? Because it could potentially segfault here.
There was a problem hiding this comment.
The fact that agent might be nil seems to be well handled, so I've opted to update the method docs to indicate that it might be nil rather than changing the method to return an error.
|
@awly Can you take a look as well? |
awly
reviewed
Apr 27, 2020
| @@ -1265,11 +1265,11 @@ func (s *discardServer) Stop() { | |||
| s.sshServer.Close() | |||
| } | |||
|
|
|||
| func (s *discardServer) HandleNewChan(conn net.Conn, sconn *ssh.ServerConn, newChannel ssh.NewChannel) { | |||
| func (s *discardServer) HandleNewChan(ccx *sshutils.ConnectionContext, newChannel ssh.NewChannel) { | |||
There was a problem hiding this comment.
I deliberately assumed the convention of referring to sshutils.ConnectionContext as ccx to handle the fact that it is frequently in-scope at the same time as srv.ServerContext, which is already conventionally called ctx.
Comment on lines
+453
to
+456
| if c.Parent == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Shouldn't c.Parent always be set?
There was a problem hiding this comment.
Removed nil checks for methods which modify state. All the getters on the zero value of srv.ConnectionContext return zero values themselves instead of panicking (a fact that some tests rely on), so I kept the nil checks on the getters in order to preserve this behavior.
| // make sure the socket is gone after we closed the connection. | ||
| err = s.clt.Close() | ||
| c.Assert(err, IsNil) | ||
| s.clt = nil |
There was a problem hiding this comment.
nullifying clt prevents test-failure due to double-close in the suite's cleanup function. Added comment to clarify.
Comment on lines
+30
to
+31
| // ConnectionContext manages connection-level state. | ||
| type ConnectionContext struct { |
There was a problem hiding this comment.
Context is overloaded in Go.
How about just ServerConn or Conn?
Changes the lifetime of agent forwarding to be scoped to the underlying ssh connection, instead of the specific ssh channel which initially passed the agent forwarding request.
fspmarshall
force-pushed
the
fspmarshall/fix-agent-forwarding
branch
from
b4bf099
to
33b8803
Compare
fspmarshall
added a commit
that referenced
this pull request
May 19, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
May 28, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
Jun 6, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
Jun 10, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
Jun 10, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
Jun 22, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
added a commit
that referenced
this pull request
Jun 24, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the lifetime of agent forwarding to be scoped to the underlying ssh connection, instead of the specific ssh channel which initially passed the agent forwarding request.
Previous behavior was inconsistent with how openssh handles agent forwarding, and was causing issues with applications which rely on creating multiple separate
execsessions on a single connection.Fixes #3471